Clover coverage report - PMD - 3.7 Coverage timestamp: Wed May 31 2006 09:25:59 EDT FRAMES NO FRAMES |
file stats: | LOC: | 51 |  | Methods: | 3
| NCLOC: | 42 |  | Classes: | 1
Source file | Conditionals | Statements | Methods | TOTAL
MethodArgumentCouldBeFinal.java | 91.7% | 94.4% | 100% | 93.9% |

1 |  | /**
2 |  | * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
3 |  | */
4 |  | package net.sourceforge.pmd.rules.optimization;
5 |  |
6 |  | import net.sourceforge.pmd.ast.ASTClassOrInterfaceDeclaration;
7 |  | import net.sourceforge.pmd.ast.ASTFormalParameter;
8 |  | import net.sourceforge.pmd.ast.ASTMethodDeclaration;
9 |  | import net.sourceforge.pmd.symboltable.NameOccurrence;
10 |  | import net.sourceforge.pmd.symboltable.Scope;
11 |  | import net.sourceforge.pmd.symboltable.VariableNameDeclaration;
12 |  |
13 |  | import java.util.Iterator;
14 |  | import java.util.List;
15 |  | import java.util.Map;
16 |  |
17 |  | public class MethodArgumentCouldBeFinal extends AbstractOptimizationRule {
18 |  |
19 | 11 | public Object visit(ASTClassOrInterfaceDeclaration node, Object data) {
20 | 11 | if (node.isInterface()) {
21 | 0 | return data;
22 |  | }
23 | 11 | return super.visit(node, data);
24 |  | }
25 |  |
26 | 11 | public Object visit(ASTMethodDeclaration meth, Object data) {
27 | 11 | if (meth.isNative() || meth.isAbstract()) {
28 | 2 | return data;
29 |  | }
30 | 9 | Scope s = meth.getScope();
31 | 9 | Map decls = s.getVariableDeclarations();
32 | 9 | for (Iterator i = decls.keySet().iterator(); i.hasNext();) {
33 | 14 | VariableNameDeclaration var = (VariableNameDeclaration) i.next();
34 | 14 | if (!var.getAccessNodeParent().isFinal() && (var.getAccessNodeParent() instanceof ASTFormalParameter) && !assigned((List) decls.get(var))) {
35 | 7 | addViolation(data, var.getAccessNodeParent(), var.getImage());
36 |  | }
37 |  | }
38 | 9 | return data;
39 |  | }
40 |  |
41 | 9 | private boolean assigned(List usages) {
42 | 9 | for (Iterator j = usages.iterator(); j.hasNext();) {
43 | 6 | NameOccurrence occ = (NameOccurrence) j.next();
44 | 6 | if (occ.isOnLeftHandSide() || occ.isSelfAssignment()) {
45 | 2 | return true;
46 |  | }
47 | 4 | continue;
48 |  | }
49 | 7 | return false;
50 |  | }
51 |  | }