    1   package test.net.sourceforge.pmd.rules;
    2
    3   import net.sourceforge.pmd.PMD;
    4   import net.sourceforge.pmd.Rule;
    5   import net.sourceforge.pmd.RuleSetNotFoundException;
    6   import test.net.sourceforge.pmd.testframework.SimpleAggregatorTst;
    7   import test.net.sourceforge.pmd.testframework.TestDescriptor;
    8
    9   public class UnusedNullCheckInEqualsTest extends SimpleAggregatorTst {
    10
    11      private Rule rule;
    12
    13      public void setUp() throws RuleSetNotFoundException {
    14          rule = findRule("basic", "UnusedNullCheckInEquals");
    15      }
    16
    17      public void testAll() {
    18          runTests(new TestDescriptor[]{
    19              new TestDescriptor(TEST1, "failure case", 1, rule),
    20              new TestDescriptor(TEST2, "different var, 'tis ok", 0, rule),
    21              new TestDescriptor(TEST3, "proper usage", 0, rule),
    22              new TestDescriptor(TEST4, "variation of correct usage", 0, rule),
    23              //new TestDescriptor(TESTN, "shouldn't this fail?", 1, rule),
    24          });
    25      }
    26
    27      private static final String TEST1 =
    28              "public class Foo {" + PMD.EOL +
    29              " public void bar() {" + PMD.EOL +
    30              "  if (x != null && foo.getBar().equals(x)) {} " + PMD.EOL +
    31              " }" + PMD.EOL +
    32              "}";
    33
    34      private static final String TEST2 =
    35              "public class Foo {" + PMD.EOL +
    36              " public void bar() {" + PMD.EOL +
    37              "  if (x != null && foo.equals(y)) {} " + PMD.EOL +
    38              " }" + PMD.EOL +
    39              "}";
    40
    41      private static final String TEST3 =
    42              "public class Foo {" + PMD.EOL +
    43              " public void bar() {" + PMD.EOL +
    44              "  if (x != null && x.equals(y)) {} " + PMD.EOL +
    45              " }" + PMD.EOL +
    46              "}";
    47
    48      private static final String TEST4 =
    49              "public class Foo {" + PMD.EOL +
    50              " public void bar() {" + PMD.EOL +
    51              "  if (x != null && \"Foo\".equals(y)) {} " + PMD.EOL +
    52              "  if (y.equals(x)) {} " + PMD.EOL +
    53              " }" + PMD.EOL +
    54              "}";
    55
    56      private static final String TESTN =
    57              "public class Foo {" + PMD.EOL +
    58              " public void bar() {" + PMD.EOL +
    59              "  if (x != null && y.equals(x)) {} " + PMD.EOL +
    60              " }" + PMD.EOL +
    61              "}";
    62
    63  }